fix(SPLIT): correctly pick the adequate message layout for temporary message #16599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DorraJaouad
added
regression
feature: chat 💬
Antreesy
reviewed
Jan 9, 2026
| && !this.message.parent | ||
| && !this.isThreadStarterMessage | ||
| && this.message.messageParameters.length === 0 | ||
| && !this.message.messageParameters.length |
Contributor
There was a problem hiding this comment.
This should be Object.keys(this.message.messageParameters).length === 0, as messageParameters could be either empty array [ ] or an object with data { mention-user: { } }
For temporary messages it falls back to:
const messageParameters: ChatMessage['messageParameters'] = {}
If we implement fake parameters (e.g. parse mentions from autocomplete), that would be working just fine
…mplate Signed-off-by: Dorra Jaouad <[email protected]>
Antreesy
force-pushed
the
fix/16594/short-message-jump
branch
from
db742c7 to
21e8dbe
Compare
Antreesy
approved these changes
Jan 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🏡 After
🏁 Checklist